This repository was archived by the owner on Dec 31, 2022. It is now read-only.
Change default encoding to UTF-8 for better international support#167
Open
colinphill wants to merge 1 commit intoquamotion:masterfrom
Open
Change default encoding to UTF-8 for better international support#167colinphill wants to merge 1 commit intoquamotion:masterfrom
colinphill wants to merge 1 commit intoquamotion:masterfrom
Conversation
Contributor
|
@colinphill Sorry it took so long to review this. This change seems reasonable. Did you test it locally with paths which contain UTF-8 characters? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As is, the communications channel uses Latin-1 encoding which doesn't support the majority of the Unicode character set properly. This change allows commands and file-syncs to be better compliant with extended characters.