refactor(asr): add recognition provider registry - #45
Merged
Merged
Conversation
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
PYTHONPATH=src /Users/bytedance/personal/doubao-say/.venv/bin/python -m unittest tests.unit.test_recognition_providers/Users/bytedance/personal/doubao-say/.venv/bin/python -m ruff check src tests packagingPYTHONPATH=src /Users/bytedance/personal/doubao-say/.venv/bin/python -m compileall -q src tests/unit/test_recognition_providers.pygit diff --checkValidation gap
The local macOS environment does not provide the Linux PyGObject
gimodule, so GTK-dependent tests and the fullmake checkare delegated to Linux CI. This refactor intentionally exposes no new provider or user-visible flow.Dependency and review order
Root of the recognition-provider stack. Review and merge this PR before the Deepgram transport PR.
Current CI dependency (2026-09-25)
The existing visual failures are from the shared Ark model endpoint returning HTTP 429
RateLimitExceeded.EndpointRPMExceeded; the existing Pages build failure says the published history manifest has an unsupported shape. Both are outside this provider-registry diff. #43 contains the serialized visual runs, retry policy, and Midscene 1.13 report/manifest support and is still under visual validation. After #43 is accepted intomain, refresh this stacked branch and rerun its checks before merging #45. The Python core, coverage, package, and contract checks on this PR passed in its last run.