Conversation
quanru
merged commit Sep 26, 2026
c8ced44
into
research/omarchy-plugin-visual-review
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failed run 36226802829 passed its visual case but failed report extraction because the custom assertion wrapper produced no reportable step evidence. The research branch now uses a native Midscene
aiAssert(818cddb), and run 36227368689 passed both the case and screenshot extraction. This PR adds a contract test that executes the assertion renderer with escaped input and ensures the smoke case remains a native, reportable Midscene step.