fix: keep Midscene CI report stable for custom visual steps - #59
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the report-capture failure in run 36226802829 independently of the Omarchy plugin research branch. The visual case passed, but a custom Node did not forward
agentDetails, soreport-cases.mjsthrew before the Summary table could be produced. This change recovers a screenshot only when its execution time unambiguously matches the step (or an older one-step report has a single screenshot); otherwise it keeps the passed case and native report link in the table with no per-node screenshot. Explicitly linked AI steps with missing screenshots still fail. Replayed the original run artifact successfully; 39 local contract tests pass.