Skip to content

Add interop/qasm #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cirq/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,15 @@
neutral_atoms,
api,
google,
interop,

# Applications
experiments,
# Extra (nothing should depend on these)
testing,
contrib,

# For interoperation
interop,
)
# End dependency order list of sub-modules

Expand All @@ -69,7 +72,6 @@
InsertStrategy,
PointOptimizationSummary,
PointOptimizer,
QasmOutput,
TextDiagramDrawer,
Unique,
)
Expand Down Expand Up @@ -100,6 +102,8 @@
)

from cirq.interop import (
circuit_from_qasm,
QasmOutput,
quirk_json_to_circuit,
quirk_url_to_circuit,
)
Expand Down
3 changes: 0 additions & 3 deletions cirq/circuits/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
from cirq.circuits.text_diagram_drawer import (
TextDiagramDrawer,)

from cirq.circuits.qasm_output import (
QasmOutput,)

from cirq.circuits.circuit import (
Circuit,)
from cirq.circuits.circuit_dag import (
Expand Down
5 changes: 3 additions & 2 deletions cirq/circuits/circuit.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
from cirq.circuits._bucket_priority_queue import BucketPriorityQueue
from cirq.circuits.insert_strategy import InsertStrategy
from cirq.circuits.text_diagram_drawer import TextDiagramDrawer
from cirq.circuits.qasm_output import QasmOutput
from cirq.type_workarounds import NotImplementedType
import cirq._version

Expand Down Expand Up @@ -1625,7 +1624,7 @@ def _to_qasm_output(
header: Optional[str] = None,
precision: int = 10,
qubit_order: 'cirq.QubitOrderOrList' = ops.QubitOrder.DEFAULT,
) -> QasmOutput:
) -> 'cirq.QasmOutput':
"""Returns a QASM object equivalent to the circuit.

Args:
Expand All @@ -1640,6 +1639,8 @@ def _to_qasm_output(
cirq._version.__version__)
qubits = ops.QubitOrder.as_qubit_order(qubit_order).order_for(
self.all_qubits())
# HACK: avoid circular import
from cirq.interop.qasm.qasm_output import QasmOutput
return QasmOutput(operations=self.all_operations(),
qubits=qubits,
header=header,
Expand Down
12 changes: 12 additions & 0 deletions cirq/circuits/qasm_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import numpy as np

from cirq import ops, linalg, protocols, value
from cirq._compat import deprecated

if TYPE_CHECKING:
import cirq
Expand All @@ -29,6 +30,9 @@
@value.value_equality(approximate=True)
class QasmUGate(ops.SingleQubitGate):

@deprecated(deadline='v0.8',
fix='Use `cirq.interop.qasm_output.QasmUGate` instead.',
name='cirq.circuits.qasm_output.QasmUGate')
def __init__(self, theta, phi, lmda) -> None:
"""A QASM gate representing any single qubit unitary with a series of
three rotations, Z, Y, and Z.
Expand Down Expand Up @@ -81,6 +85,10 @@ def _value_equality_values_(self):

@value.value_equality
class QasmTwoQubitGate(ops.TwoQubitGate):

@deprecated(deadline='v0.8',
fix='Use `cirq.interop.qasm_output.QasmTwoQubitGate` instead.',
name='cirq.circuits.qasm_output.QasmTwoQubitGate')
def __init__(self, kak: linalg.KakDecomposition) -> None:
"""A two qubit gate represented in QASM by the KAK decomposition.

Expand Down Expand Up @@ -144,6 +152,9 @@ def __repr__(self) -> str:
class QasmOutput:
valid_id_re = re.compile(r'[a-z][a-zA-Z0-9_]*\Z')

@deprecated(deadline='v0.8',
fix='Use `cirq.interop.qasm_output.QasmOutput` instead.',
name='cirq.circuits.qasm_output.QasmOutput')
def __init__(self,
operations: 'cirq.OP_TREE',
qubits: Tuple['cirq.Qid', ...],
Expand Down Expand Up @@ -276,6 +287,7 @@ def fallback(op):
return NotImplemented

if len(op.qubits) == 1:
print('SDFKSLJKJLFHASLHRIUERIUFREIHUFDFDSHFKKHFKD')
return QasmUGate.from_matrix(mat).on(*op.qubits)
return QasmTwoQubitGate.from_matrix(mat).on(*op.qubits)

Expand Down
Loading