Skip to content

Add problem matchers #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Mar 4, 2025

GitHub Problem Matchers are a mechanism that enable workflow steps to scan the outputs of GitHub Actions for regex patterns and automatically write annotations in the workflow summary page. Using Problem Matchers allows information to be displayed more prominently in the GitHub user interface.

This add problem matchers for Pylint, Pytest, MyPy, and Black output. More problem matchers can be added in the future as more checks are added to the CI workflows.

@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 4, 2025
@mhucka mhucka self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (0551f85) to head (0c0d866).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7122   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files        1093     1093           
  Lines       95528    95528           
=======================================
  Hits        93745    93745           
  Misses       1783     1783           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka marked this pull request as ready for review March 7, 2025 22:34
@mhucka mhucka requested review from vtomole and a team as code owners March 7, 2025 22:34
@mhucka mhucka requested a review from maffoo March 7, 2025 22:34
@mhucka mhucka requested a review from pavoljuhas March 9, 2025 22:14
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a temporary commit that would introduce all errors handled here?

It will verify if matchers work and show what is their output like.

@mhucka
Copy link
Contributor Author

mhucka commented Mar 21, 2025

Can you please add a temporary commit that would introduce all errors handled here?

It will verify if matchers work and show what is their output like.

Just so I'm clear, you mean, make a commit as part of this PR, to make changes that will trigger the problem matchers?

It's a great idea to have test cases. I wonder if we could actually add test files somewhere in a directory and leave them there, then (after verifying the beahvior) configure the CI checks to ignore the directory?

If so, what would be a good location for those test files?

@mhucka mhucka added area/ci priority/after-1.5 Leave for after the Cirq 1.5 release labels Mar 24, 2025
@mhucka mhucka marked this pull request as draft April 9, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci priority/after-1.5 Leave for after the Cirq 1.5 release size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants