-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add problem matchers #7122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add problem matchers #7122
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7122 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 1093 1093
Lines 95528 95528
=======================================
Hits 93745 93745
Misses 1783 1783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a temporary commit that would introduce all errors handled here?
It will verify if matchers work and show what is their output like.
Just so I'm clear, you mean, make a commit as part of this PR, to make changes that will trigger the problem matchers? It's a great idea to have test cases. I wonder if we could actually add test files somewhere in a directory and leave them there, then (after verifying the beahvior) configure the CI checks to ignore the directory? If so, what would be a good location for those test files? |
GitHub Problem Matchers are a mechanism that enable workflow steps to scan the outputs of GitHub Actions for regex patterns and automatically write annotations in the workflow summary page. Using Problem Matchers allows information to be displayed more prominently in the GitHub user interface.
This add problem matchers for Pylint, Pytest, MyPy, and Black output. More problem matchers can be added in the future as more checks are added to the CI workflows.