Skip to content

Clarify docstring of is_parameterized #7215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Clarify docstring of is_parameterized #7215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cirq-core/cirq/protocols/resolve_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def is_parameterized(val: Any) -> bool:

A value is parameterized when it has an `_is_parameterized_` method and
that method returns a truthy value, or if the value is an instance of
sympy.Basic.
sympy.Basic. Note this covers sympy constants such as `sympy.pi`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit that can be ignored: I would perhaps change that line to

`sympy.Basic`. Note this covers SymPy constants such as `sympy.pi`.

but really, looking at the rest of the file, it has other places where capitalization and backticks are inconsistent, so it could be left to some later sweep to deal with such nonessential things.


Returns:
True if the gate has any unresolved Symbols
Expand Down