-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix top-level .gitignore file to track (not ignore) files in docs/build #7216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While most `build` directories are generated and should be ignored, `docs/build` has legitimate sources and should be tracked. Also ignore the `out/` directory only at the repository root.
Oh, wow, good catch. I wonder how long docs/build has been ignored :-) |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7216 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 1104 1104
Lines 96352 96352
=======================================
Hits 94569 94569
Misses 1783 1783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It was not quite ignored, but in a recent change I had |
Verified this is the only misignored directory by getting empty output from git ls-files | sed "s,[^/]\+$,do-not-ignore-me," | uniq | git check-ignore --stdin The output at c34989b is
|
While most
build
directories are generated and should be ignored,docs/build
has legitimate sources and should be tracked.Also ignore the
out/
directory only at the repository root.