Use a different GitHub Actions action for the PR size-labeler workflow #7219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous labeler was buggy and poorly written.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7219 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 1104 1104
Lines 96352 96352
=======================================
Hits 94569 94569
Misses 1783 1783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
reviewed
Apr 2, 2025
pavoljuhas
approved these changes
Apr 2, 2025
Co-authored-by: Pavol Juhas <[email protected]>
mhucka
force-pushed
the
mh-change-pr-labeler-action
branch
from
4ad7ce3 to
c758f16
Compare
Thanks for the excellent suggested chanages. I still don't know if the workflow permissions will work after merging. There is a restriction with token permissions in PRs from forks, so the current failures may be due to that. Unfortunately, if there's still a different permission problem, it's being masked by this failure and we won't know until the workflow is on the main branch. (I guess the right way to do it would have been to use a branch in the Cirq repo itself, instead of in a fork.) |
There is no way to get the error messages from the labeler action. We need to get the output if we want to note that something failed without failing the whole workflow. Thankfully, the action can be invoked more directly using `podman`, and it's not hard to revise the workflow to capture the output and write it as an annotation on the summary page.
mhucka
force-pushed
the
mh-change-pr-labeler-action
branch
from
f04262e to
c213bd5
Compare
mhucka
changed the title
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Use a different action for size labeler GHA The previous labeler was buggy and poorly written. * Need set permissions for id-token * Update .github/pr-size-labels.yaml Co-authored-by: Pavol Juhas <[email protected]> * Widen the scope of excluded package-lock.json files * Improve explanation of how the settings work * Don't fail the workflow if labeling fails * Invoke the labeler program directly There is no way to get the error messages from the labeler action. We need to get the output if we want to note that something failed without failing the whole workflow. Thankfully, the action can be invoked more directly using `podman`, and it's not hard to revise the workflow to capture the output and write it as an annotation on the summary page. * Clarify comments some more --------- Co-authored-by: Pavol Juhas <[email protected]>
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous GitHub Actions used as the labeling action was buggy. Switching to a different action that looks more promising.