Skip to content

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Apr 3, 2025

Let us avoid test-only argument in circuit_to_pdf_using_qcircuit_via_tex.
Mock Document.generate_pdf instead so we can test without the latexmk program.

Related to #7220

@pavoljuhas pavoljuhas force-pushed the circuit-to-pdf-without-prepare_only-argument branch from 0a3811b to d581a26 Compare April 4, 2025 00:47
Let us avoid test-only argument in `circuit_to_pdf_using_qcircuit_via_tex`.
Mock `Document.generate_pdf` so we can test without the `latexmk` program.

Related to quantumlib#7220
@pavoljuhas pavoljuhas force-pushed the circuit-to-pdf-without-prepare_only-argument branch from d581a26 to 4aab03a Compare April 4, 2025 00:53
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (56c13ab) to head (4aab03a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7227      +/-   ##
==========================================
- Coverage   98.66%   98.65%   -0.01%     
==========================================
  Files        1106     1106              
  Lines       95864    95874      +10     
==========================================
+ Hits        94580    94589       +9     
- Misses       1284     1285       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas marked this pull request as ready for review April 4, 2025 01:57
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners April 4, 2025 01:57
@pavoljuhas pavoljuhas requested a review from dstrain115 April 4, 2025 01:57
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Nice job.

@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 4, 2025
Merged via the queue into quantumlib:main with commit 4436b85 Apr 4, 2025
39 checks passed
@pavoljuhas pavoljuhas deleted the circuit-to-pdf-without-prepare_only-argument branch April 4, 2025 16:54
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
…uantumlib#7227)

Let us avoid test-only argument in `circuit_to_pdf_using_qcircuit_via_tex`.
Mock `Document.generate_pdf` so we can test without the `latexmk` program.

Related to quantumlib#7220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants