Skip to content

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Apr 4, 2025

Change the instructions involving "apt install" to use the file
apt-system-requirements.txt, which is the purpose of the file.

Resolves #6934

Change the instructions involving "apt install" to use the file
`apt-system-requirements.txt`, which is the purpose of the file.
@mhucka mhucka marked this pull request as ready for review April 4, 2025 19:00
@mhucka mhucka requested review from a team and vtomole as code owners April 4, 2025 19:00
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title so it is descriptive without having to lookup the issue.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (4436b85) to head (36ff3bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7230   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files        1106     1106           
  Lines       95914    95914           
=======================================
  Hits        94630    94630           
  Misses       1284     1284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka changed the title Fix issue #6934 Fix issue #6934: explain how to use apt-system-requirements.txt Apr 4, 2025
@mhucka
Copy link
Contributor Author

mhucka commented Apr 4, 2025

Please update the PR title so it is descriptive without having to lookup the issue.

Haha, I just updated it because I thought the same thing, and then read your comment.

@mhucka mhucka added this pull request to the merge queue Apr 4, 2025
Merged via the queue into quantumlib:main with commit 1d4860d Apr 4, 2025
40 checks passed
@mhucka mhucka deleted the mh-explain-apt-sys-requirements branch April 4, 2025 20:18
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
Change the instructions involving "apt install" to use the file
`apt-system-requirements.txt`, which is the purpose of the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move apt-system-requirements.txt into apt-list-dev-tools.txt

2 participants