Skip to content

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners April 15, 2025 22:55
@pavoljuhas pavoljuhas requested a review from maffoo April 15, 2025 22:55
@pavoljuhas pavoljuhas force-pushed the add-labeler-permission branch from f2997fe to ee91c20 Compare April 15, 2025 22:56
@mhucka
Copy link
Contributor

mhucka commented Apr 15, 2025

It's frustrating how hard it is to test the token permissions. Less than an hour ago, I ran the labeler using the GitHub "run workflow" button for all the open PRs and it worked (and labeled all of them).

@pavoljuhas
Copy link
Collaborator Author

It's frustrating how hard it is to test the token permissions. Less than an hour ago, I ran the labeler using the GitHub "run workflow" button for all the open PRs and it worked (and labeled all of them).

My apologies for messing it up in the first place.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas enabled auto-merge April 15, 2025 23:00
@mhucka
Copy link
Contributor

mhucka commented Apr 15, 2025

It's frustrating how hard it is to test the token permissions. Less than an hour ago, I ran the labeler using the GitHub "run workflow" button for all the open PRs and it worked (and labeled all of them).

My apologies for messing it up in the first place.

Pfffft. No apologies needed! I mean, I reviewed that change and thought "oh, okay, he's probably right".

@mhucka
Copy link
Contributor

mhucka commented Apr 15, 2025

Testing the workflows is the worst part about GitHub Actions.

@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (7f570b3) to head (ee91c20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7277   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files        1106     1106           
  Lines       96042    96042           
=======================================
  Hits        94764    94764           
  Misses       1278     1278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into quantumlib:main with commit fe86bda Apr 15, 2025
39 checks passed
@pavoljuhas pavoljuhas deleted the add-labeler-permission branch April 15, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants