Skip to content

CI - add ruff check of the code #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025

Conversation

pavoljuhas
Copy link
Collaborator

  • Add minimum ruff tool configuration to pyproject.toml
  • CI - add ruff to the "Lint check" CI job

Partially implements #7371

@github-actions github-actions bot added the size: S 10< lines changed <50 label May 24, 2025
@pavoljuhas
Copy link
Collaborator Author

@pavoljuhas pavoljuhas marked this pull request as ready for review May 24, 2025 00:31
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners May 24, 2025 00:31
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (1c0ba5b) to head (c5b29a9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7372      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       97585    97641      +56     
==========================================
+ Hits        96303    96357      +54     
- Misses       1282     1284       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally optional: perhaps this file should be renamed to something like lint.env.txt or lint-tools.env.txt, to be more in line with the contents and ci.yml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done in c5b29a9

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with an optional minor and ignorable suggestion.

Thanks for doing this.

@pavoljuhas pavoljuhas enabled auto-merge May 28, 2025 21:57
@pavoljuhas pavoljuhas added this pull request to the merge queue May 28, 2025
Merged via the queue into quantumlib:main with commit 852997c May 28, 2025
32 of 35 checks passed
@pavoljuhas pavoljuhas deleted the ci-add-ruff-check branch May 28, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants