-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CI - add ruff check of the code #7372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Verifying output as colorized at https://github.com/quantumlib/Cirq/actions/runs/15221472630/job/42817712311?pr=7372#step:6:11 |
This reverts commit cff82d4.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7372 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 1112 1112
Lines 97585 97641 +56
==========================================
+ Hits 96303 96357 +54
- Misses 1282 1284 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally optional: perhaps this file should be renamed to something like lint.env.txt or lint-tools.env.txt, to be more in line with the contents and ci.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, done in c5b29a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with an optional minor and ignorable suggestion.
Thanks for doing this.
Partially implements #7371