-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Generate reproducible dev-versions from the last commit time #7597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pavoljuhas
merged 4 commits into
quantumlib:main
from
pavoljuhas:use-utc-commit-time-for-dev-version
Aug 29, 2025
Merged
Generate reproducible dev-versions from the last commit time #7597
pavoljuhas
merged 4 commits into
quantumlib:main
from
pavoljuhas:use-utc-commit-time-for-dev-version
Aug 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7597 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 1103 1103
Lines 99683 99683
=======================================
Hits 97198 97198
Misses 2485 2485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aa10ad8
to
fa5c406
Compare
Produce timestamp string with respect to the UTC time zone. Also ensure the working repository is in a pristine state.
Test at the human-produced commit instead of at the GitHub-generated merge.
No need to unset `CIRQ_PRE_RELEASE_VERSION` as it is not used in setup.py files anymore.
169474a
to
3914c15
Compare
mhucka
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ddddddanni
pushed a commit
to ddddddanni/Cirq
that referenced
this pull request
Sep 1, 2025
…lib#7597) Produce timestamp string with respect to the UTC time zone. Also ensure the working repository is in a pristine state. Partially implements quantumlib#6502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produce timestamp string with respect to the UTC time zone.
Also ensure the working repository is in a pristine state.
Partially implements #6502