Skip to content

Conversation

pavoljuhas
Copy link
Collaborator

As of #7187 setup.py files do not need CIRQ_PRE_RELEASE_VERSION
as an environment variable. Here we scrub it from the environment.

As of quantumlib#7187 setup.py files do not need CIRQ_PRE_RELEASE_VERSION
as an environment variable.  Here we scrub it from the environment.
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners August 30, 2025 01:11
@github-actions github-actions bot added the Size: XS <10 lines changed label Aug 30, 2025
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (c517794) to head (2dd4002).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7614   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files        1103     1103           
  Lines       99683    99683           
=======================================
  Hits        97198    97198           
  Misses       2485     2485           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas requested a review from mhucka August 30, 2025 01:30
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Sep 2, 2025
Merged via the queue into quantumlib:main with commit 12b443e Sep 2, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the drop-unnecessary-environment-variable branch September 2, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants