Skip to content

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Aug 30, 2025

Skip any build directories when searching for _version.py files.
These may contain temporary copies of _version.py files which should
be ignored.

Fixes #7602

Do not include the top directory in version file search
as it only replaces some sub-package version twice.
Look for them only in subdirectories of the sub-package root.
This excludes `_version.py` copies in temporary build directories
created by setuptools.
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners August 30, 2025 01:45
@pavoljuhas pavoljuhas requested a review from maffoo August 30, 2025 01:45
@github-actions github-actions bot added the Size: XS <10 lines changed label Aug 30, 2025
@pavoljuhas pavoljuhas requested a review from dstrain115 August 30, 2025 01:46
@pavoljuhas pavoljuhas marked this pull request as draft August 30, 2025 01:56
@pavoljuhas pavoljuhas marked this pull request as ready for review August 30, 2025 02:19
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.50%. Comparing base (c517794) to head (bbda5fc).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
dev_tools/modules.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7615      +/-   ##
==========================================
- Coverage   97.50%   97.50%   -0.01%     
==========================================
  Files        1103     1103              
  Lines       99683    99685       +2     
==========================================
+ Hits        97198    97199       +1     
- Misses       2485     2486       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavoljuhas pavoljuhas added this pull request to the merge queue Sep 2, 2025
Merged via the queue into quantumlib:main with commit 9672295 Sep 2, 2025
34 of 35 checks passed
@pavoljuhas pavoljuhas deleted the deflake-replace_version branch September 2, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"dev_tools/modules.py replace_version" may operate on temporary build files

2 participants