-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Tighten the search for actual version sources #7615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten the search for actual version sources #7615
Conversation
Do not include the top directory in version file search as it only replaces some sub-package version twice.
Look for them only in subdirectories of the sub-package root. This excludes `_version.py` copies in temporary build directories created by setuptools.
This reverts commit f1743a1.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7615 +/- ##
==========================================
- Coverage 97.50% 97.50% -0.01%
==========================================
Files 1103 1103
Lines 99683 99685 +2
==========================================
+ Hits 97198 97199 +1
- Misses 2485 2486 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Skip any
build
directories when searching for_version.py
files.These may contain temporary copies of
_version.py
files which shouldbe ignored.
Fixes #7602