Skip to content

Increase np.isclose tolerance for mitigated expectation value assertion #7627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

Increase np.isclose tolerance for mitigated expectation value assertion #7627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
addacaf
Increase np.isclose tolerance for mitigated expectation value assertion
ddddddanni Sep 1, 2025
5a3d66e
Also add @cirq.testing.retry_once_with_later_random_values decor
ddddddanni Sep 1, 2025
dd51998
Remove the tag
ddddddanni Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cirq-core/cirq/contrib/paulistring/pauli_string_measurement_with_readout_mitigation_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def test_pauli_string_measurement_errors_no_noise() -> None:
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)
assert isinstance(
pauli_string_measurement_results.calibration_result,
Expand Down Expand Up @@ -189,7 +189,7 @@ def test_pauli_string_measurement_errors_with_coefficient_no_noise() -> None:
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)
assert isinstance(
pauli_string_measurement_results.calibration_result,
Expand Down Expand Up @@ -243,7 +243,7 @@ def test_group_pauli_string_measurement_errors_no_noise_with_coefficient() -> No
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)
assert isinstance(
pauli_string_measurement_results.calibration_result,
Expand Down Expand Up @@ -286,7 +286,7 @@ def test_pauli_string_measurement_errors_with_noise() -> None:
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)

assert isinstance(
Expand Down Expand Up @@ -337,7 +337,7 @@ def test_group_pauli_string_measurement_errors_with_noise() -> None:
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)

assert isinstance(
Expand Down Expand Up @@ -398,7 +398,7 @@ def test_many_circuits_input_measurement_with_noise() -> None:
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)
assert isinstance(
pauli_string_measurement_results.calibration_result,
Expand Down Expand Up @@ -517,7 +517,7 @@ def test_many_circuits_with_coefficient() -> None:
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)
assert isinstance(
pauli_string_measurement_results.calibration_result,
Expand Down Expand Up @@ -588,7 +588,7 @@ def test_many_group_pauli_in_circuits_with_coefficient() -> None:
_ideal_expectation_based_on_pauli_string(
pauli_string_measurement_results.pauli_string, final_state_vector
),
atol=max(4 * pauli_string_measurement_results.mitigated_stddev, 0.1),
atol=10 * pauli_string_measurement_results.mitigated_stddev,
)
assert isinstance(
pauli_string_measurement_results.calibration_result,
Expand Down