Skip to content

Conversation

hoisinberg
Copy link
Collaborator

@hoisinberg hoisinberg commented Sep 3, 2025

The cirq-google/cirq_google/cloud contains only generated code.

@hoisinberg hoisinberg requested review from a team and vtomole as code owners September 3, 2025 18:37
@github-actions github-actions bot added the size: S 10< lines changed <50 label Sep 3, 2025
@dstrain115
Copy link
Collaborator

Looks like it is complaining a lot about unused noqa commands now. Otherwise, seems fine.

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (9672295) to head (7211011).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7633   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files        1103     1103           
  Lines       99709    99732   +23     
=======================================
+ Hits        97222    97246   +24     
+ Misses       2487     2486    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If cirq-google/cirq_google/cloud/ has only generated files, it can be excluded from ruff completely, please see inline comment.

Otherwise LGTM.

@pavoljuhas pavoljuhas added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit d7f81f4 Sep 3, 2025
39 checks passed
@pavoljuhas pavoljuhas deleted the u/hoisinberg/cirq-google-gen-code-checks branch September 3, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants