Skip to content

Conversation

pavoljuhas
Copy link
Collaborator

Avoid testing files that changed in the main after branching off
the current branch. This unifies base-commit resolution across all
check/*-changed-* scripts.

Avoid testing files that changed in the `main` after branching off
the current branch.  This unifies base-commit resolution across all
`check/*-changed-*` scripts.
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners September 8, 2025 23:30
@github-actions github-actions bot added the size: S 10< lines changed <50 label Sep 8, 2025
@pavoljuhas pavoljuhas requested a review from mhucka September 8, 2025 23:30
Merge-base with upstream/main is empty for an independent branch.
Use upstream/main as is in such case.
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (9f3b2c5) to head (3ee085a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7642      +/-   ##
==========================================
- Coverage   99.56%   99.37%   -0.20%     
==========================================
  Files        1088     1078      -10     
  Lines       96083    96056      -27     
==========================================
- Hits        95667    95452     -215     
- Misses        416      604     +188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Sep 11, 2025
Merged via the queue into quantumlib:main with commit fc5bee5 Sep 11, 2025
34 of 35 checks passed
@pavoljuhas pavoljuhas deleted the pytest-changed-in-our-branch branch September 11, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants