Skip to content

Conversation

seunomonije
Copy link
Contributor

@seunomonije seunomonije commented Sep 17, 2025

Fixes #7159 (patch)

  • Changed tsconfig.json to target primarily ESM instead of CommonJS, and handles all the downstream implications to keep repo functioning.
  • nyc doesn't support ESM natively, so switched to c8 for now
  • For mocha, need to tap into some experimental features to allow extensionless imports in typescript, a next step could be to modify the tests to not allow this
  • Modified webpack config to be ESM compatible

All check pass, but with warnings:

(node:4511) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("./node_modules/ts-node/esm.mjs", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
(node:4511) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

@github-actions github-actions bot added the Size: XS <10 lines changed label Sep 17, 2025
@github-actions github-actions bot added size: S 10< lines changed <50 and removed Size: XS <10 lines changed labels Sep 17, 2025
@github-actions github-actions bot added Size: XS <10 lines changed and removed size: S 10< lines changed <50 labels Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (7673240) to head (8eab54a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7652   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files        1080     1080           
  Lines       96378    96378           
=======================================
  Hits        95775    95775           
  Misses        603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added size: M 50< lines changed <250 and removed Size: XS <10 lines changed labels Sep 17, 2025
@seunomonije seunomonije changed the title manually bump and install packages Manually bump chai and pixelmatch, switch from commonJS base to ESM Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant