Skip to content

CI - unblock type check with a temporary pin to numpy-2.2 #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

CI - unblock type check with a temporary pin to numpy-2.2 #7658

merged 1 commit into from
Sep 19, 2025

Conversation

pavoljuhas
Copy link
Collaborator

Type check fails for numpy-2.3.3. Add temporary pin
to numpy-2.2.x to let it pass.

Workaround for #7657

@pavoljuhas
CI - unblock type check with a temporary pin to numpy-2.2
d6c6fae 
Type check fails for numpy-2.3.3.  Add temporary pin
to numpy-2.2.x to let it pass.

Workaround for quantumlib#7657
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners September 19, 2025 07:03
@pavoljuhas pavoljuhas requested a review from maffoo September 19, 2025 07:03
@github-actions github-actions bot added the Size: XS <10 lines changed label Sep 19, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (163a087) to head (d6c6fae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7658   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files        1080     1080           
  Lines       96378    96378           
=======================================
  Hits        95775    95775           
  Misses        603      603

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas requested a review from mhucka September 19, 2025 16:58
@pavoljuhas pavoljuhas added this pull request to the merge queue Sep 19, 2025
Merged via the queue into quantumlib:main with commit 2845910 Sep 19, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the ci-pin-numpy-2.2 branch September 19, 2025 17:53
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this pull request Sep 22, 2025
@pavoljuhas
Revert "CI - unblock type check with a temporary pin to numpy-2.2 (qu…
9f0f2a2 
…antumlib#7658)"

This reverts commit 2845910.
@pavoljuhas pavoljuhas mentioned this pull request Sep 22, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 24, 2025
@pavoljuhas
Fix type-checking issues for numpy-2.3.3 (#7661)
23afd92 
- revert "CI - unblock type check with a temporary pin to numpy-2.2
(#7658)"
- purge unused "type: ignore" comments
- fix small issues showing for numpy-2.3.3
- allow convertible types for the dtype argument of
`StateVectorSimulationState`

Fixes #7657
@NoureldinYosri NoureldinYosri mentioned this pull request Sep 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhucka mhucka mhucka approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@maffoo maffoo Awaiting requested review from maffoo maffoo is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees

No one assigned

Labels

Size: XS <10 lines changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavoljuhas @mhucka