Skip to content

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Oct 21, 2025

the tests seem to be stable with newer versions of numpy

fixes #6770

@NoureldinYosri NoureldinYosri requested review from a team and vtomole as code owners October 21, 2025 19:05
@github-actions github-actions bot added the Size: XS <10 lines changed label Oct 21, 2025
@NoureldinYosri NoureldinYosri requested a review from mhucka October 21, 2025 19:06
@pavoljuhas
Copy link
Collaborator

Are there any other x-passing tests?

Perhaps we could iterate them here, ie, enable all that pass locally and then reinstate xfail for those that fail on Mac or Windows.

Otherwise LGTM.

@NoureldinYosri
Copy link
Collaborator Author

NoureldinYosri commented Oct 21, 2025

@pavoljuhas the two tests I unmarked are the only ones

Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (bc6dab9) to head (5437a39).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7712      +/-   ##
==========================================
- Coverage   99.38%   99.38%   -0.01%     
==========================================
  Files        1091     1091              
  Lines       97815    97813       -2     
==========================================
- Hits        97214    97212       -2     
  Misses        601      601              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NoureldinYosri NoureldinYosri added this pull request to the merge queue Oct 21, 2025
Merged via the queue into quantumlib:main with commit 036f969 Oct 21, 2025
65 of 66 checks passed
@NoureldinYosri NoureldinYosri deleted the remove_6765 branch October 21, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate Possible Numerical Instability in 2q and 3q analytical decompositions

2 participants