-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix docs/google snippet error and add to snippets_test #7803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
232aca0
Fix snippet in calibration.md
ToastCheng 039549c
Fix snippet in specification.md
ToastCheng 433f461
Fix snippets in engine.md
ToastCheng e207a60
Include docs/google in snippets_test
ToastCheng 540c514
Merge branch 'main' into i7787-2
ToastCheng 663c861
Allow multi-line test overrides in snippets
pavoljuhas 912211b
Import the `mock` module for snippets execution namespace
pavoljuhas d2222f4
Use more genuine mocks for cirq_google.Engine snippets
pavoljuhas eeb068e
Use more genuine Engine mock in calibration.md
pavoljuhas cb293d3
Use virtual engine to test snippets in specification.md
pavoljuhas 5c7ea25
Merge branch 'main' into i7787-2
pavoljuhas f723233
Format snippets with `black -q --line-length=84 -`
pavoljuhas 8b0ebac
Format snippets in devices.md with `black -q --line-length=84 -`
pavoljuhas 7b5e4ba
Document that test_substitution may be multi-line
pavoljuhas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the behavior changed, maybe add a short explanation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, done in 7b5e4ba.