Start adding coverage for density_matrix_kronecker_product function#7858
Closed
joesho112358 wants to merge 2 commits intoquantumlib:mainfrom
Closed
Start adding coverage for density_matrix_kronecker_product function#7858joesho112358 wants to merge 2 commits intoquantumlib:mainfrom
joesho112358 wants to merge 2 commits intoquantumlib:mainfrom
Conversation
joesho112358
commented
Jan 27, 2026
Comment on lines
+675
to
+677
| calculated_result_shape = tuple( | ||
| map(lambda x, y: (x / 2 + y / 2) * 2, matrix_1_array.shape, matrix_2_array.shape) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
hi @vtomole, i saw you were assigned to this PR automatically and wanted to call out that this is a draft because i am getting:
> assert matrix_result.shape == calculated_result_shape
E assert (2, 4, 2, 4) == (6.0, 6.0)
from the assertion that follows. Not sure where my math is failing, but guessing i am not fully understanding the function's docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to boost test coverage on the density_matrix_kronecker_product function