Skip to content

Fix several broken links in Markdown files - #8311

Open
mhucka wants to merge 3 commits into
quantumlib:mainfrom
mhucka:fix-md-files-bad-urls
Open

Fix several broken links in Markdown files#8311
mhucka wants to merge 3 commits into
quantumlib:mainfrom
mhucka:fix-md-files-bad-urls

Conversation

@mhucka

@mhucka mhucka commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This PR simply replaces some broken hyperlinks in a small number of Markdown files.

This PR simply replaces some broken hyperlinks in a small number of
Markdown files.
@mhucka
mhucka requested a review from a team as a code owner September 8, 2026 02:51
@mhucka
mhucka requested a review from viathor September 8, 2026 02:51
@github-actions github-actions Bot added the size: S 10< lines changed <50 label Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.59%. Comparing base (cfa8a84) to head (c204d24).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8311   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        1125     1125           
  Lines      103250   103250           
=======================================
  Hits       102829   102829           
  Misses        421      421           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread docs/dev/versions.md
* Similarly, symbols in vendor packages, like [cirq-google](https://quantumai.google/reference/python/cirq_google/all_symbols), [cirq-aqt](https://quantumai.google/reference/python/cirq_aqt/all_symbols) are also not covered by the compatibility guarantee.
* If a symbol is available through the `cirq` Python module or its submodules, but is not documented, then it is **not** considered part of the public API.

<a name="what-is-not-covered"></a>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto-generated anchor seems to be the same. Please remove.

@mhucka mhucka Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto-generated anchor seems to be the same. Please remove.

Actually, it was hand-generated. I added after finding that markdown link checkers flagged the earlier reference in the file (#what-is-not-covered) as not found. I think it's because the emphasis text in the header (_not_) causes Markdown processors to create a different link than #what-is-not-covered.

Alternatively, I could change the _not_ to plain not and avoid the problem.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By auto-generated I meant that if I visit https://github.com/quantumlib/Cirq/blob/main/docs/dev/versions.md and hover the mouse over that section heading, the browser shows the same anchor. In other words, GitHub already interprets that heading as having the #what-is-not-covered anchor.

Sure, changing to plain "not" will probably appease the checkers.

@pavoljuhas pavoljuhas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comment before merge.
Thank you for correcting these!

@pavoljuhas pavoljuhas added the ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants