Run OSV scan on PRs if requirements files are changed #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sample workflows for the OSV scanner make it run on every PR, but that doesn't make sense to me; better would be to run it only if a requirements file is changed in a PR. So, that's what this does.
The documentation is poor, and the meaning of `--skip-git` is ambiguous, and it doesn't seem to reduce performance noticeably, so lets' just skip that option.
mhucka
added a commit
to mhucka/OpenFermion
that referenced
this pull request
Sep 25, 2025
* Run OSV scan on PRs if requirements files are changed The sample workflows for the OSV scanner make it run on every PR, but that doesn't make sense to me; better would be to run it only if a requirements file is changed in a PR. So, that's what this does. * Remove --skip-git option from osv-scanner The documentation is poor, and the meaning of `--skip-git` is ambiguous, and it doesn't seem to reduce performance noticeably, so lets' just skip that option. * Rename a couple of jobs for consistency with others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample workflows for the OSV scanner make it run on every PR, but
that doesn't make sense to me; better would be to run it only if a
requirements file is changed in a PR. So, that's what this does.