Skip to content

Conversation

@mhucka
Copy link
Contributor

@mhucka mhucka commented Sep 25, 2025

The hadolint warning DL3009 is only relevant when optimizing a docker container's size. It's not needed for security or other reasons. Not only is this rule annoying; following the rule can also increase docker image build times. The benefit does not seem to outweight the drawbacks, so I added it to the list of ignored rules.

Conversely, DL3047 (about the syntax of CMD statements) is probably better to keep, as a matter of modern practices surrounding Dockerfiles.

The `hadolint` warning DL3009 is only relevant when optimizing a docker
container's size. It's not needed for security or other reasons. Not
only is it annoying; following the rule can also increase docker image
build times. The benefit does not seem to outweight the drawbacks.
@mhucka mhucka marked this pull request as ready for review September 25, 2025 21:33
@mhucka mhucka added area/docker Issues and PRs related to the use of Docker area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics labels Sep 25, 2025
@mhucka mhucka added this pull request to the merge queue Sep 26, 2025
Merged via the queue into quantumlib:master with commit ba5d0b8 Sep 26, 2025
24 checks passed
@mhucka mhucka deleted the mh-update-hadolint-config branch September 26, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics area/docker Issues and PRs related to the use of Docker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants