Move pytest options to pyproject.toml#1279
Conversation
In addition to being the more modern approach, this lets us start to consolidate tool options into a single well-known locadtion instead of burying them in a nonstandard location like `dev_tools/conf/`.
Now that the options are in pyproject.toml, the explicit argument is no longer necessary.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the pytest configuration from a standalone dev_tools/conf/pytest.ini file into the pyproject.toml file under the [tool.pytest.ini_options] section. Correspondingly, the check/pytest script has been updated to remove the explicit configuration file flag. I have no feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request migrates the pytest configuration from a standalone .ini file to the pyproject.toml file. Specifically, it moves test markers and warning filters to the [tool.pytest.ini_options] section and updates the check/pytest script to remove the explicit configuration file flag, allowing pytest to use the default configuration discovery. I have no feedback to provide.
mhucka
added
area/devops
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Please fix the omit list in pyproject.toml before submitting.
Otherwise LGTM.
| omit = [ | ||
| "./profiling/performance_benchmarks.py", | ||
| "./dev_tools/*", | ||
| "./git/*", |
There was a problem hiding this comment.
I think it should be .git, .github instead of git, github.
That said are these necessary at all? I would expect that coverage would skip the .git directory by default as that must be a very common case. .github does not have any python files so excluding it is redundant.
2 participants
In addition to being the more modern approach, this lets us start to consolidate tool options into a single well-known location, and also lets us simplify the check scripts.
One of the PRs that will resolve #1268.