fix(docs): resolve Taylor expansion flakiness in Fermi-Hubbard FQE tutorial (#870) - #1451
Open
akushnarov wants to merge 2 commits into
Open
fix(docs): resolve Taylor expansion flakiness in Fermi-Hubbard FQE tutorial (#870)#1451akushnarov wants to merge 2 commits into
akushnarov wants to merge 2 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Fermi-Hubbard tutorial notebook by setting a random seed to ensure reproducibility when initializing the wavefunction randomly, and reducing the time evolution parameter e_time from 0.9 to 0.1. There are no review comments, so no additional feedback is provided.
akushnarov
force-pushed
the
fix/issue-870-hubbard-notebook-flakiness
branch
from
September 8, 2026 12:43
f1fd3cd to
a56c874
Compare
akushnarov
force-pushed
the
fix/issue-870-hubbard-notebook-flakiness
branch
from
September 8, 2026 12:51
a56c874 to
44a9a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sporadic numerical divergence and flakiness during time evolution in the Fermi-Hubbard tutorial notebook (
docs/fqe/tutorials/fermi_hubbard.ipynb).Fixes #870
Problem & Root Cause
In
docs/fqe/tutorials/fermi_hubbard.ipynb, the time evolution demo calls:init_wfn.set_wfn(strategy="random")without an explicit random seed, creating arbitrary initial spectral weights.e_time = 0.9resulted in a large Taylor expansion parameter (Solution & Approach
np.random.seed(0)) before generating the random initial state for deterministic reproducibility.e_time = 0.1(fidelity == 1.0) against matrix exponentiation.Validation
check/nbformatpassed cleanly.