Skip to content

SelectHubbard refactor #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

SelectHubbard refactor #1732

wants to merge 4 commits into from
+885 −72

Conversation

mpharrigan
Copy link
Collaborator

Use subroutines for SelectHubbard.

  • Wrap complex metaprogramming in bespoke hubbard bloqs for documentability, serializability.
  • move towards support for symbolic decomposition: the select circuit now theoretically could be constructed with symbolic n. There are some complications when using the cirq-style decomposition though.
  • unit test the phasing subroutine using the new phased-classical simulation tools.

I created a new bloq notebook for select and its subroutines. And I put the existing hubbard model page under "chemistry" where it belongs.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncrubin ncrubin Awaiting requested review from ncrubin

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bloqs/chemistry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mpharrigan