Add parallelism to check/mypy - #1935
Open
mhucka wants to merge 4 commits into
Open
Conversation
mhucka
marked this pull request as ready for review
August 11, 2026 16:08
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the check/mypy script to run mypy in parallel using the -n flag when mypy version 2.0 or higher is detected. The feedback highlights a potential issue where os.cpu_count() could return None or 1, which would cause a TypeError or result in an invalid worker count of 0. A robust fallback mechanism is suggested to ensure a minimum of 1 worker.
Per review comment by Gemini Code Assist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make use of the
-nflag that Mypy 2.0+ supports for parallel workers.