Import proto functions conditionally in testing.py - #1938
Open
mhucka wants to merge 2 commits into
Open
Conversation
The import of proto funnctions in `assert_bloq_example_serializes` in testing.py failed in the minimal test environment, where protobufs is not imported. It was not caught because testing_test.py did not have a test case for it. This wraps the import in testing.py in a conditional, and adds a test to testing_test.py.
mhucka
marked this pull request as ready for review
August 17, 2026 22:12
mhucka
requested review from
NoureldinYosri,
fdmalone,
mpharrigan and
tanujkhattar
and removed request for
NoureldinYosri and
mpharrigan
August 17, 2026 22:12
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates assert_bloq_example_serializes to catch ModuleNotFoundError when importing serialization modules, raising a BloqCheckException.na if protobuf is not installed, and adds corresponding unit tests. The feedback suggests a more robust check in the tests by attempting to import from qualtran.serialization.bloq instead of google.protobuf directly, ensuring the test behaves correctly if protobuf is installed but generated proto files are missing.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import of proto funnctions in
assert_bloq_example_serializesin testing.py failed in the minimal test environment, where protobufs is not imported. It was not caught because testing_test.py did not have a test case for it.This wraps the import in testing.py in a conditional, and adds a test to testing_test.py.