Skip to content

Conversation

@snichet
Copy link
Contributor

@snichet snichet commented Aug 1, 2025

Add images in notebook that are not correctly formatting on website: https://quantumai.google/cirq/experiments/lattice_gauge/lattice_gauge.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@snichet
Copy link
Contributor Author

snichet commented Aug 1, 2025

@mhucka @eliottrosenberg Thanks for the patience. Hopefully this addresses #393 (comment)

@mhucka
Copy link
Collaborator

mhucka commented Aug 2, 2025

@snichet Thank you for this work! It looks like it only needs a quick run of

pip install -r dev_tools/requirements/deps/tensorflow-docs.txt
./dev_tools/nbformat --apply

and then commit & push the changes. Sorry for the hassle!

@mhucka
Copy link
Collaborator

mhucka commented Sep 2, 2025

@snichet and @eliottrosenberg in order to move things along, I went ahead and did the notebook formatting and pushed against @snichet's branch. If everything passes CI checks, I'll proceed with merging.

@snichet thanks again for your work on this!

@mhucka mhucka added the area/docs Concerns documentation label Sep 2, 2025
@snichet
Copy link
Contributor Author

snichet commented Sep 2, 2025

Thanks for picking this up, @mhucka. Sorry to let it slip. I really appreciate all your help!

@mhucka mhucka self-assigned this Sep 2, 2025
@mhucka mhucka changed the title Add image files for notebook Fix #393: add image files for lattice_gauge notebook Sep 2, 2025
@mhucka mhucka merged commit a60f6d6 into quantumlib:master Sep 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Concerns documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants