Fix #189: handle use_physical_cz argument #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `cz_to_sqrt_iswap` passed an argument that it doesn't have. Based on the description of `use_physical_cz`, it seems that the intention was to call `cirq.CZ` when `use_physical_cz=True`.
pavoljuhas
approved these changes
Aug 19, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Before merging, please delete the cz_correction argument of build_otoc_circuits as it is unused.
Remove unused `cz_correction` argument of `build_otoc_circuits`. Thanks to [@pavoljuhas for noticing it in review](quantumlib#423 (review)).
mhucka
added a commit
to snichet/ReCirq
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
cz_to_sqrt_iswappassed an argument that it doesn't have. Based on the description ofuse_physical_cz, it seems that the intention was to callcirq.CZwhenuse_physical_cz=True.