Fix #433: remove unused imports #432
Conversation
This removes unused imports across many files.
| from matplotlib import pyplot as plt | ||
|
|
||
| # this is for older systems with matplotlib <3.2 otherwise 3d projections fail | ||
| from mpl_toolkits import mplot3d # pylint: disable=unused-import |
There was a problem hiding this comment.
I would not remove this. As per the comment, this is needed for 3d matplotlib graphs.
There was a problem hiding this comment.
OK, I must admit I was going by the comments about the problem being in matplotlib versions before 3.2. ReCirq itself does not pin the matplotlib version, and since 3.2 released in 2020, I guess I made the assumption that people who import seaborn (from the top-level requirements.txt file) would get a matplotlib version newer than 3.2. (Seaborn requires matplotlib > 3.4.)
Anyway, I'll remove this change, because it's not essential anyway and surely not worth spending more time on …
There was a problem hiding this comment.
Yeah, not sure how relevant it still is, but it's really annoying to figure out and debug when it (used to?) happens, so it's worth it just to keep it for now.
Per recommendation of @dstrain115 in [review comment](quantumlib#432 (comment)), putting back the import of `mplot3d`.
2 participants
This removes unused imports across many files. The approach taken was to get a list of the unused imports using
and then fixing the cases that it listed.