Skip to content

remove macos-13 from workflows and update the type stub to accommodate the latest numpy version #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoureldinYosri merged 2 commits into from
Oct 20, 2025
Merged

remove macos-13 from workflows and update the type stub to accommodate the latest numpy version #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68e363c
remove macos-13 from workflows
NoureldinYosri Oct 20, 2025
0feacd5
fix mypy
NoureldinYosri Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-24.04", "ubuntu-24.04-arm", "macos-13", "macos-14"]
os: ["ubuntu-24.04", "ubuntu-24.04-arm", "macos-14"]

runs-on: ${{ matrix.os }}

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ jobs:
arch: auto
- os: macos-14
arch: auto
- os: macos-13
arch: auto

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/stable-release-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ jobs:
arch: auto
- os: macos-14
arch: auto
- os: macos-13
arch: auto

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
Expand Down
2 changes: 2 additions & 0 deletions tunits/core/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ class Value(Generic[NumericalT], WithUnit, np.generic, SupportsIndex):
real: 'Value'
imag: 'Value'

# needed because np.generic declars __new__ as abstract.
Copy link
Contributor

@mhucka mhucka Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome to handle PRs as you wish, of course, but I wanted to flag this in case it was included accidentally: this looks like an unrelated change. (Unrelated to removing macos-13.)

Copy link
Collaborator Author

@NoureldinYosri NoureldinYosri Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this the CI is broken because of a recent update to numpy ... numpy now declares new as an abstract method which it didn't used to do.

Copy link
Collaborator Author

@NoureldinYosri NoureldinYosri Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why the commit that added this change is called "fix mypy"

Copy link
Contributor

@mhucka mhucka Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but what I'm trying to say is, that change should probably be done as a separate PR, rather than being a part of this PR.

Copy link
Collaborator Author

@NoureldinYosri NoureldinYosri Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update the title and description ... small fixes to the CI can be interwoven into PRs

def __new__(cls: type[T], *args: Any, **kwargs: Any) -> T: ...
@classmethod
def from_proto(cls: type[T], msg: tunits_pb2.Value) -> T: ...
def to_proto(self, msg: tunits_pb2.Value | None = None) -> tunits_pb2.Value: ...
Expand Down
Loading