Skip to content

return NotImplemted for unsupported operations in __array_ufunc__ and implement matmul #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoureldinYosri merged 3 commits into from
Jan 9, 2026
Merged

return NotImplemted for unsupported operations in __array_ufunc__ and implement matmul #84

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc918fe
return NotImplemted for unsupported operations in __array_ufunc__
NoureldinYosri Jan 9, 2026
d1ae49b
implement matmul
NoureldinYosri Jan 9, 2026
080f7ca
nit
NoureldinYosri Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tunits/core/cython/with_unit_value_array.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class ValueArray(WithUnit):
if self._is_dimensionless():
return getattr(ufunc, method)(*(np.asarray(x) for x in inputs), **kwargs)

raise NotImplemented
return NotImplemented

@property
def dtype(WithUnit self) -> np.dtype:
Expand All @@ -160,4 +160,4 @@ class ValueArray(WithUnit):
def to_proto(self, msg: Optional['tunits_pb2.ValueArray'] = None) -> 'tunits_pb2.ValueArray':
ret = _ndarray_to_proto(self.value, msg)
ret.units.extend(_units_to_proto(self.display_units))
return ret
return ret
Loading