Rewrite dev_tools/test_libs.sh #710
Merged
+65
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue #705, and also improves the script by making it more efficient and adding a --help option.
|
Resolves issue #705. |
mhucka
added
area/devops
mhucka
changed the title
An empty value for $filter_avx ends up leaving a quoted empty string in the list of args, and bazel doesn't like that.
This option is not available with the old version of Bash on MacOS that the GitHub runners still use.
This rewritten version improves upon the previous one in the following ways: - Automatically determines whether to exclude AVX and SSE cases from what it builds and tests. It queries the host computer about the features it supports in order to make this determination. - Doesn't uses a hardwired list of cases to build and test. Instead, it uses Bazel filters based on tags. - Adds a `--help` option.
pavoljuhas
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Please see inline comments, otherwise LGTM.
As a side note, the editorconfig specifies an indent of 2 for shell scripts, but the file is indented at 4. Please reformat or update the editorconfig value.
Co-authored-by: Pavol Juhas <[email protected]>
Co-authored-by: Pavol Juhas <[email protected]>
Revised code per suggestions by @pavoljuhas .
pavoljuhas
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #705, and also improves in several ways:
--helpoption.