Move most cibuildwheel options to pyproject.toml #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial contents are settings for cibuildwheel and pytest. The cibuildwheel settings came from the GitHub Actions workflow for building wheels. Putting the settings here means the settings are available in more situations, such as when running cibuildwheel manually for testing, or if we create more scripts or workflows that run cibuildwheel.
mhucka
changed the title
Otherwise, brew complains in a way that looks like errors in the GHA run logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
pyproject.tomlfile to the top level of the repository. The initial contents are settings forcibuildwheelandpytest. Thecibuildwheelsettings came from the GitHub Actions workflow for building wheels. Putting the settings here means the settings are available in more situations, such as when runningcibuildwheelmanually for testing, or if we create more scripts or workflows that runcibuildwheel. Since command-line options and environment variables overridecibuildwheelvalues inpyproject.toml, these additions should not affect existing scripts and workflows.The purpose of doing this now is to prepare for revised GitHub Actions workflows coming in another PR. These changes here need to be in place before the workflow changes.
Note: CI checks are failing, but not due to this file; it's because the CI workflows and other changes need to be made.