Skip to content

Move the bazel rules for the python wrapper to MODULE.bazel #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

NoureldinYosri
Copy link
Contributor

@NoureldinYosri NoureldinYosri commented Jun 10, 2025

For some reason using WORKSPACE makes it hard to link stim with the python wrapper -or maybe I'm just writing the wrong bazel rules- This PR moves the rules needed for the python wrapper to MODULE.bazel and adds the rules needed to depend on pypi libraries.

note that bazel deprecated WORKSPACE and will drop support for it by the end of the year https://bazel.build/external/migration but they allow using both at the same time during migration. so this
PR starts the migration from WORKSPACE to bzlmod

part of #17

@NoureldinYosri NoureldinYosri requested a review from LalehB June 10, 2025 05:19
Copy link
Collaborator

@LalehB LalehB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks Nour 👍🏻

@NoureldinYosri NoureldinYosri merged commit 0d24008 into quantumlib:main Jun 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants