Issue 211#268
Merged
Merged
Conversation
mcruzdev
reviewed
Mar 28, 2025
mcruzdev
reviewed
Mar 28, 2025
Member
mcruzdev
left a comment
mcruzdev
left a comment
There was a problem hiding this comment.
Hi @jghagemann, looks really good. I left some comments, I think we need to change little things.
Member
|
@jghagemann this issue is not related with your changes, I check it tomorrow! |
mcruzdev
reviewed
Mar 30, 2025
mcruzdev
reviewed
Mar 30, 2025
mcruzdev
approved these changes
Mar 30, 2025
Member
|
@jghagemann, it looks like some files from main ended up in your branch but shouldn't be there. Could you fix it? |
jghagemann
force-pushed
the
issue-211
branch
2 times, most recently
from
7461aef to
cb4bd53
Compare
Member
|
Hi @jghagemann, we need to change this one too |
Member
|
@zhfeng could you take a look? |
Member
|
Thanks a lot @jghagemann! |
Contributor
|
@mcruzdev are you going to do a new release? |
Member
|
I think yes! |
Member
|
Do you would like to do it? |
Contributor
|
Ha, feel free to do a new release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding codestarts to quarkus-dapr
This PR should close #211