fix: Kubernetes env mappings from secret generate wrong values.yaml entry#495
fix: Kubernetes env mappings from secret generate wrong values.yaml entry#495matheusandre1 wants to merge 1 commit into
Conversation
|
@gastaldi Can you guide me in the process? |
|
@matheusandre1 I don't have much expertise in this extension, better ask the @quarkiverse/quarkiverse-helm team |
cmoulliard
left a comment
cmoulliard
left a comment
There was a problem hiding this comment.
Can you document what you do/improved here as this is not so simple to understand from application.properties env variable, what we expect to have part of the helm values file generated and next consumed part of a Helm template: deployment ?
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
I think this is a valid bug.
|
@matheusandre1 @cmoulliard asked me to verify this PR so I built your PR and updated the reproducer linked in the issue to use quarkus-helm 1.4.1-SNAPSHOT. The TEST env is still present in the generated values.yaml. How are you verifying this fix on your end? For me the reproducer also deploys successfully without this PR. |
|
See also the commend I posted on the issue folks: #454 (comment) |
4 participants
Resolves: #454