Refactor: Replace JBoss Logger with Quarkus Log API #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @gastaldi please, can you review this PR? |
gastaldi
reviewed
Jun 3, 2025
...er-heroes/rest-fights/src/main/java/io/quarkus/workshop/superheroes/fight/FightResource.java
Show resolved
Hide resolved
gastaldi
suggested changes
Jun 6, 2025
Member
gastaldi
left a comment
gastaldi
left a comment
There was a problem hiding this comment.
It looks good, but it looks like it reorganized imports unrelated to this change?
Author
Thanks again for the review, Gastaldi. I've reverted the imports to their original organization, only removing the JBoss log import that was already removed from the class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of
@Inject org.jboss.logging.Loggerwith theio.quarkus.logging.Logstatic API throughout the project.Motivation for this change:
Logstatic API simplifies logging calls by removing the need for@Injectand instance creation, leading to cleaner code.