Fix narayana-jta restart in dev mode, issue 35839 #52181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
marcosgopen
force-pushed
the
issue35839
branch
from
4e14f69 to
a5d7066
Compare
gsmet
reviewed
Jan 26, 2026
Comment on lines
59
to
80
| recoveryManagerService = null; | ||
| // Do NOT set recoveryManagerService = null - maintain singleton pattern | ||
| // so datasources closing after destroy() can still properly deregister |
Member
There was a problem hiding this comment.
But this will leak the original class loader, won't it?
Contributor
Author
There was a problem hiding this comment.
You are right, I'll update the PR
marcosgopen
force-pushed
the
issue35839
branch
from
a5d7066 to
d3b2f4c
Compare
marcosgopen
force-pushed
the
issue35839
branch
from
6addeba to
7fd6575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deregister xa resources helpers in stop method before terminating the recoveryManager
Please note: stop() is called before destroy()