Add Gradle support for proper dependency tracking to app model#52226
Open
reaver585 wants to merge 1 commit intoquarkusio:mainfrom
Open
Add Gradle support for proper dependency tracking to app model#52226reaver585 wants to merge 1 commit intoquarkusio:mainfrom
reaver585 wants to merge 1 commit intoquarkusio:mainfrom
Conversation
quarkus-bot
bot
added
area/devtools
Saingsophea
approved these changes
Jan 28, 2026
reaver585
force-pushed
the
maven-model-in-gradle
branch
2 times, most recently
from
c20f0dd to
bfff9f1
Compare
aloubyansky
reviewed
Jan 28, 2026
aloubyansky
reviewed
Jan 28, 2026
...adle-model/src/main/java/io/quarkus/gradle/tooling/GradleAssistedMavenModelResolverImpl.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Jan 28, 2026
...adle/gradle-model/src/main/java/io/quarkus/gradle/tooling/GradleApplicationModelBuilder.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Jan 28, 2026
...adle/gradle-model/src/main/java/io/quarkus/gradle/tooling/GradleApplicationModelBuilder.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Jan 28, 2026
...adle/gradle-model/src/main/java/io/quarkus/gradle/tooling/GradleApplicationModelBuilder.java
Outdated
Show resolved
Hide resolved
reaver585
force-pushed
the
maven-model-in-gradle
branch
from
bfff9f1 to
bf8d2e3
Compare
reaver585
changed the title
reaver585
commented
Feb 4, 2026
...ols/gradle/gradle-model/src/main/java/io/quarkus/gradle/tooling/DependencyInfoCollector.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Feb 4, 2026
...ols/gradle/gradle-model/src/main/java/io/quarkus/gradle/tooling/DependencyInfoCollector.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Feb 4, 2026
...ols/gradle/gradle-model/src/main/java/io/quarkus/gradle/tooling/DependencyInfoCollector.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Feb 4, 2026
...ols/gradle/gradle-model/src/main/java/io/quarkus/gradle/tooling/DependencyInfoCollector.java
Outdated
Show resolved
Hide resolved
reaver585
commented
Feb 4, 2026
...ols/gradle/gradle-model/src/main/java/io/quarkus/gradle/tooling/DependencyInfoCollector.java
Outdated
Show resolved
Hide resolved
reaver585
commented
Feb 4, 2026
...ols/gradle/gradle-model/src/main/java/io/quarkus/gradle/tooling/DependencyInfoCollector.java
Outdated
Show resolved
Hide resolved
reaver585
force-pushed
the
maven-model-in-gradle
branch
from
57570d2 to
a81adfc
Compare
reaver585
commented
Feb 16, 2026
...gradle-model/src/main/java/io/quarkus/gradle/tooling/dependency/DependencyDataCollector.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Feb 16, 2026
...le-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusApplicationModelTask.java
Show resolved
Hide resolved
aloubyansky
reviewed
Feb 16, 2026
devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/QuarkusPlugin.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Feb 17, 2026
...gradle-model/src/main/java/io/quarkus/gradle/tooling/dependency/DependencyDataCollector.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Feb 17, 2026
| LaunchMode.DEVELOPMENT); | ||
|
|
||
| Provider<DefaultProjectDescriptor> projectDescriptor = ProjectDescriptorBuilder.buildForApp(project); | ||
| DependencyDataCollector depDataCollector = new DependencyDataCollector(project); |
Member
There was a problem hiding this comment.
I am thinking whether we should be creating DependencyDataCollector per task instead. So it could be garbage collected as soon as the task has been configured.
Contributor
Author
There was a problem hiding this comment.
There could be a benefit to keeping it on the project level.
E.g. :quarkusTest task among its dependencies has both quarkusGenerateAppModel and quarkusGenerateTestAppModel. In this scenario, I can confirm that test app model is significantly faster (40-70 ms) than the regular app model (~1.2s) because we have lots of cache hits in the collector.
aloubyansky
reviewed
Feb 17, 2026
| task.getProjectDescriptor().set(projectDescriptor); | ||
| task.getLaunchMode().set(launchMode); | ||
| task.getDeclaredDependencies().set(declaredDepsProvider); | ||
| task.getDeclaredDependenciesSnapshot().set(declaredDepsProvider.map(DependencyDataCollector::toSnapshot)); |
Member
There was a problem hiding this comment.
Just to confirm, will the value of declareDepsProvider be resolved only once for this task?
Contributor
Author
There was a problem hiding this comment.
Technically it's twice, but since everything is cached inside the collector, second time the time it takes is very short (<10ms), and I chose simplicity over performance in this case since performance hit is negligible.
reaver585
force-pushed
the
maven-model-in-gradle
branch
from
e93f948 to
3f5b1b8
Compare
reaver585
changed the title
reaver585
force-pushed
the
maven-model-in-gradle
branch
from
3f5b1b8 to
dc83430
Compare
aloubyansky
reviewed
Feb 18, 2026
| .provider(() -> dependencyDataCollector.collectDeclaredDependencies( | ||
| project, classpath.getDeploymentConfiguration())); | ||
| task.getProjectDescriptor().set(projectDescriptor); | ||
| task.getDisableDeclaredDependencyCollector().set(isDisableDeclaredDependencyCollector(project)); |
Member
There was a problem hiding this comment.
Do we need another property for the disable option or we could just not set the property values and check for property.isPresent() in the task?
Contributor
Author
There was a problem hiding this comment.
Leaving a response here as well for historic purposes.
MapProperty as well as ListProperty need to be explicitly set to nulls in order for an isPresent() check to return false. I think it makes the code less clear, so for now I decided to keep what we have here.
But let me know if you feel strongly about it.
This comment has been minimized.
This comment has been minimized.
reaver585
force-pushed
the
maven-model-in-gradle
branch
from
dc83430 to
6370dc9
Compare
This comment has been minimized.
This comment has been minimized.
With this change we collect declared and resolved dependencies for Gradle builds and wire them into the application model. A boolean prop 'disableDeclaredDependencyCollector' is available to disable this feature. Co-authored-by: Alexey Loubyansky <olubyans@redhat.com>
reaver585
force-pushed
the
maven-model-in-gradle
branch
from
6370dc9 to
66e2bb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we collect declared and resolved
dependencies for Gradle builds and wire them into
the application model.
A boolean prop 'disableDeclaredDependencyCollector'
is available to disable this feature.
Co-authored-by: Alexey Loubyansky olubyans@redhat.com