Prevent server's OpenTelemetry Context getting lost on client read timeout#53115
Open
brunobat wants to merge 1 commit intoquarkusio:mainfrom
Open
Prevent server's OpenTelemetry Context getting lost on client read timeout#53115brunobat wants to merge 1 commit intoquarkusio:mainfrom
brunobat wants to merge 1 commit intoquarkusio:mainfrom
Conversation
…t client read timeout
|
/cc @radcortez (opentelemetry) |
gsmet
reviewed
Mar 17, 2026
Comment on lines
+73
to
+78
| // Connection reset (e.g. client read timeout) can be triggered while a worker is still be running. | ||
| // Will end the span to record the failure but don't close the scope yet because it would erase the OTel context | ||
| // and mess with ongoing child spans | ||
| if (spanOperation.tryEndSpan()) { | ||
| instrumenter.end(spanOperation.getSpanContext(), (REQ) request, (RESP) response, failure); | ||
| } |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ❌ | Build report | Produce report and add it as job summary |
Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52239
The
tryEndSpan()is needed to avoid double closing the span, if a server side response is made available.