Conversation
gsmet
left a comment
There was a problem hiding this comment.
Thanks for having a look at it!
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Beans.java
Outdated
Show resolved
Hide resolved
Ladicek
left a comment
There was a problem hiding this comment.
LGTM, but Guillaume has a good point.
7e5bb2c to
6ab42ea
Compare
6ab42ea to
0dfa5a9
Compare
0dfa5a9 to
2a7bf1b
Compare
gsmet
left a comment
There was a problem hiding this comment.
On the optimization perspective, it's all good from my side.
I let others chime in for correctness :).
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🚧 | ||
| ✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🚧 | ||
| ✔️ | JVM Tests - JDK 25 | Logs | Raw logs | 🚧 | ||
| ✔️ | JVM Tests - JDK 25 Semeru | Logs | Raw logs | 🚧 | ||
| ❌ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 Windows #
- Failing: extensions/panache/hibernate-orm-panache-kotlin/runtime extensions/panache/hibernate-reactive-panache-kotlin/runtime extensions/panache/mongodb-panache-kotlin/runtime and 2 more
! Skipped: extensions/panache/hibernate-orm-panache-kotlin/deployment extensions/panache/hibernate-reactive-panache-kotlin/deployment extensions/panache/mongodb-panache-kotlin/deployment and 5 more📦 extensions/panache/hibernate-orm-panache-kotlin/runtime
❌ Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-hibernate-orm-panache-kotlin: Compilation failure
Failed connecting to the daemon in 4 retries
📦 extensions/panache/hibernate-reactive-panache-kotlin/runtime
❌ Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:kapt (kapt) on project quarkus-hibernate-reactive-panache-kotlin: Compilation failure
Failed connecting to the daemon in 4 retries
📦 extensions/panache/mongodb-panache-kotlin/runtime
❌ Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:compile (compile) on project quarkus-mongodb-panache-kotlin: Compilation failure
Failed connecting to the daemon in 4 retries
📦 extensions/resteasy-reactive/rest-client-kotlin-serialization/tests
❌ Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-rest-client-kotlin-serialization-tests: Compilation failure
Failed connecting to the daemon in 4 retries
📦 extensions/smallrye-reactive-messaging/deployment
❌ Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-messaging-deployment: Compilation failure
Failed connecting to the daemon in 4 retries
|
The CI failures are unrelated. @mkouba Anything you want to add to this since you didn't approve? :) |
|
I merged it. I think we will have to fix the ordering issue at some point though. |
I only added caching of the callbacks because I don't think we can replace method iteration with
ClassInfo#annotations(see #49653 (comment)) nor am I aware of any other Jandex way that would be simpler. We still need to mark all the methods to account for overrides.Beans#getCallbacks()#49653