Skip to content

Optimize Beans#getCallbacks()#53157

Merged
gsmet merged 1 commit intoquarkusio:mainfrom
manovotn:beansGetCallbacks
Mar 24, 2026
Merged

Optimize Beans#getCallbacks()#53157
gsmet merged 1 commit intoquarkusio:mainfrom
manovotn:beansGetCallbacks

Conversation

@manovotn
Copy link
Copy Markdown
Contributor

@manovotn manovotn commented Mar 19, 2026

I only added caching of the callbacks because I don't think we can replace method iteration with ClassInfo#annotations (see #49653 (comment)) nor am I aware of any other Jandex way that would be simpler. We still need to mark all the methods to account for overrides.

@manovotn manovotn requested review from Ladicek and mkouba March 19, 2026 10:49
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Mar 19, 2026
Copy link
Copy Markdown
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at it!

Copy link
Copy Markdown
Member

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Guillaume has a good point.

Copy link
Copy Markdown
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the optimization perspective, it's all good from my side.

I let others chime in for correctness :).

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot bot commented Mar 19, 2026

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2a7bf1b.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🚧
✔️ JVM Tests - JDK 21 Logs Raw logs 🚧
✔️ JVM Tests - JDK 25 Logs Raw logs 🚧
✔️ JVM Tests - JDK 25 Semeru Logs Raw logs 🚧
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/panache/hibernate-orm-panache-kotlin/runtime extensions/panache/hibernate-reactive-panache-kotlin/runtime extensions/panache/mongodb-panache-kotlin/runtime and 2 more
! Skipped: extensions/panache/hibernate-orm-panache-kotlin/deployment extensions/panache/hibernate-reactive-panache-kotlin/deployment extensions/panache/mongodb-panache-kotlin/deployment and 5 more

📦 extensions/panache/hibernate-orm-panache-kotlin/runtime

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-hibernate-orm-panache-kotlin: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/panache/hibernate-reactive-panache-kotlin/runtime

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:kapt (kapt) on project quarkus-hibernate-reactive-panache-kotlin: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/panache/mongodb-panache-kotlin/runtime

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:compile (compile) on project quarkus-mongodb-panache-kotlin: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/resteasy-reactive/rest-client-kotlin-serialization/tests

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-rest-client-kotlin-serialization-tests: Compilation failure Failed connecting to the daemon in 4 retries

📦 extensions/smallrye-reactive-messaging/deployment

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.10:test-compile (test-compile) on project quarkus-messaging-deployment: Compilation failure Failed connecting to the daemon in 4 retries

@manovotn
Copy link
Copy Markdown
Contributor Author

The CI failures are unrelated.

@mkouba Anything you want to add to this since you didn't approve? :)

@gsmet gsmet merged commit db00739 into quarkusio:main Mar 24, 2026
123 of 125 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.35 - main milestone Mar 24, 2026
@gsmet
Copy link
Copy Markdown
Member

gsmet commented Mar 24, 2026

I merged it. I think we will have to fix the ordering issue at some point though.

@manovotn manovotn deleted the beansGetCallbacks branch March 24, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/arc Issue related to ARC (dependency injection)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArC - Optimize Beans#getCallbacks()

4 participants