fix: limit public suffix so work on ruby 3.1#2601
Closed
maxandersen wants to merge 1 commit intomainfrom
Closed
Conversation
|
🙈 The PR is closed and the preview is expired. |
Member
Author
|
we shuold just update to use otherw base jekyl...redoing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent Dependabot upgrade of addressable from 2.8.0 to 2.9.0 (#2597) pulled in public_suffix 7.0.5, which requires Ruby >= 3.2. The
bretfisher/jekyll-serve Docker image ships Ruby 3.1.7, causing docker compose up to fail with:
This PR pins public_suffix to < 7 in the Gemfile and updates the lockfile to use 6.0.1, which is compatible with Ruby 3.1.
Alternative is to fork
bretfisher/jekyll-servebut thought I would suggest this one first and see if any hard need for public_suffix v7