Create hyperfoil yaml rather than running wrk directly#113
Create hyperfoil yaml rather than running wrk directly#113edeandrea wants to merge 1 commit intoquarkusio:mainfrom
Conversation
4e21fa9 to
9cc21ca
Compare
|
@holly-cummins / @franz1981 Let me know what you think of this. I wasn't sure if I should modify the |
9cc21ca to
cfee564
Compare
|
I am all in to do this tbh as it allow more fine grain analysis, especially if we add more endpoints. More; I would create two hf workload:
This would help to:
This would allow comparing Quarkus and Spring with the same sustainable throughput (to the slower one - which tend to be Spring so far) and appropriate rampup to not overload it. But what we can compare? One note about it: clearly such a test configuration depends by which resource is mostly utilized till saturation (or near to): if we measure with N TPS that framework S runs w 80% of available CPU time, but in a subsequent test, we double the CPU cores, the test is not granted anymore to be CPU bound - and we need to verify it. In relation to the throughput output used - I can check with my team mates what we can do to help/improve w it but right now is already possible to parse the json and computing it ourself. |
I think the two goals of the
If those were in opposition, it would be tricky, but if both of those are better with wrk, I suggest we stick with wrk. We could add some comments in the script explaining the design choice. |
|
Re which one is better @holly-cummins we (perf team) could improve the run cmd output with ease or just NOT reuse the same script as the purpose of the two tests is not exactly the same (we trade the cognitive load for accuracy and correctness) |
|
@franz1981 the It would be nice if |
cfee564 to
0a4df76
Compare
|
Iirc there is a way to print the result in csv of the avg throughput per each phase |
|
FYI I opened https://github.com/Hyperfoil/jbang-catalog/issues/14 to help with the output of |
|
Yep @edeandrea you found the output I was mentioning. Consider that hyperfoil is using a saved csv formatted file for each run with it, so it is surely there. |
But for |
f76546a to
8316350
Compare
8316350 to
b9eb20c
Compare
This also produces the nice html reports, which are also downloaded by the
run-benchmarks.shscript :Fixes #42