Skip to content

refactor: make ErasedSegment::recursive_crawl_all return Iterator instead of Vec #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gvozdvmozgu
Copy link
Collaborator

No description provided.

Copy link

Benchmark for c52b0e9

Click to view benchmark
Test Base PR %
DepthMap::from_parent 37.9±0.38µs 38.8±1.42µs +2.37%
fix_complex_query 9.3±0.12ms 9.6±0.69ms +3.23%
fix_superlong 91.3±4.71ms 92.2±5.26ms +0.99%
parse_complex_query 2.9±0.03µs 3.0±0.04µs +3.45%
parse_expression_recursion 5.0±0.04µs 5.2±0.05µs +4.00%
parse_simple_query 800.5±6.81ns 843.6±32.50ns +5.38%

Copy link

Benchmark for 2454731

Click to view benchmark
Test Base PR %
DepthMap::from_parent 38.6±1.59µs 38.6±0.28µs 0.00%
fix_complex_query 9.1±0.05ms 9.6±0.84ms +5.49%
fix_superlong 89.8±3.92ms 87.9±4.72ms -2.12%
parse_complex_query 2.9±0.03µs 2.9±0.03µs 0.00%
parse_expression_recursion 5.2±0.22µs 5.1±0.05µs -1.92%
parse_simple_query 821.1±7.18ns 838.1±9.06ns +2.07%

Copy link

Benchmark for 9fd9355

Click to view benchmark
Test Base PR %
DepthMap::from_parent 38.6±0.27µs 38.9±0.25µs +0.78%
fix_complex_query 9.4±0.18ms 9.7±0.71ms +3.19%
fix_superlong 101.6±6.43ms 98.1±5.18ms -3.44%
parse_complex_query 2.9±0.03µs 2.9±0.04µs 0.00%
parse_expression_recursion 5.1±0.10µs 5.2±0.07µs +1.96%
parse_simple_query 828.0±15.41ns 861.1±9.70ns +4.00%

Copy link

github-actions bot commented Feb 2, 2025

Benchmark for a5e02c2

Click to view benchmark
Test Base PR %
DepthMap::from_parent 38.6±0.46µs 38.5±0.46µs -0.26%
fix_complex_query 9.2±0.10ms 9.6±0.66ms +4.35%
fix_superlong 88.8±3.00ms 88.8±3.89ms 0.00%
parse_complex_query 2.9±0.03µs 2.9±0.03µs 0.00%
parse_expression_recursion 5.0±0.04µs 5.2±0.04µs +4.00%
parse_simple_query 808.1±6.46ns 875.8±15.87ns +8.38%

@benfdking benfdking force-pushed the recursive_crawl_all branch from 955f950 to 3719d0d Compare March 6, 2025 11:42
Copy link

github-actions bot commented Mar 6, 2025

Benchmark for d7d81f7

Click to view benchmark
Test Base PR %
DepthMap::from_parent 38.3±0.33µs 38.9±0.59µs +1.57%
fix_complex_query 9.3±0.04ms 9.5±0.59ms +2.15%
fix_superlong 91.1±4.31ms 86.7±4.22ms -4.83%
parse_complex_query 2.8±0.04µs 2.9±0.08µs +3.57%
parse_expression_recursion 5.1±0.15µs 5.1±0.05µs 0.00%
parse_simple_query 807.4±13.66ns 871.6±14.80ns +7.95%

@gvozdvmozgu gvozdvmozgu force-pushed the recursive_crawl_all branch from 3719d0d to 05ea5dc Compare March 21, 2025 10:31
Copy link

Benchmark for b63853f

Click to view benchmark
Test Base PR %
DepthMap::from_parent 38.3±0.35µs 40.0±0.38µs +4.44%
fix_complex_query 9.3±0.08ms 9.5±0.48ms +2.15%
fix_superlong 102.7±5.71ms 100.6±7.48ms -2.04%
parse_complex_query 2.9±0.05µs 3.0±0.03µs +3.45%
parse_expression_recursion 5.1±0.07µs 5.3±0.06µs +3.92%
parse_simple_query 797.2±12.12ns 832.3±14.31ns +4.40%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant