-
Notifications
You must be signed in to change notification settings - Fork 31
refactor: make ErasedSegment::recursive_crawl_all return Iterator instead of Vec #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gvozdvmozgu
wants to merge
1
commit into
main
Choose a base branch
from
recursive_crawl_all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for c52b0e9Click to view benchmark
|
4def9d9
to
7d97d77
Compare
Benchmark for 2454731Click to view benchmark
|
7d97d77
to
b4dc953
Compare
Benchmark for 9fd9355Click to view benchmark
|
b4dc953
to
955f950
Compare
Benchmark for a5e02c2Click to view benchmark
|
955f950
to
3719d0d
Compare
Benchmark for d7d81f7Click to view benchmark
|
… instead of `Vec`
3719d0d
to
05ea5dc
Compare
Benchmark for b63853fClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.